Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to per-repo versioning #3615

Closed
devjgm opened this issue Mar 30, 2020 · 3 comments · Fixed by #3710
Closed

Change to per-repo versioning #3615

devjgm opened this issue Mar 30, 2020 · 3 comments · Fixed by #3710
Assignees
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@devjgm
Copy link
Contributor

devjgm commented Mar 30, 2020

Overview

As described in #3612, this repo is changing to a monorepo that will contain the code for all the Cloud C++ client libraries. Each library will live in a per-library directory, like google/cloud/$library. The repo itself will have a version number that corresponds with the versions on the https://github.com/googleapis/google-cloud-cpp/releases page. But each individual library will not contain their own version numbers. To be clear (and visually skimmable):

There will be a single per-repo version number, NOT per-library version numbers.

This differs from today where there is a repo version number, and each individual library also has their own version number. For example, today we have:

All libraries will be assumed to be Generally Available (GA) unless otherwise noted in the google/cloud/$library/README.md file.

@devjgm devjgm added the type: cleanup An internal cleanup or hygiene concern. label Mar 30, 2020
@coryan
Copy link
Contributor

coryan commented Apr 8, 2020

I think until -common is merged into the repo we will need to manually sync and keep GCS and Bigtable version numbers. @devjgm if you agree, I can send an initial PR later today.

@devjgm
Copy link
Contributor Author

devjgm commented Apr 8, 2020

I'm not sure I understand why we need to wait for -common to be merged into this repo. I was thinking that we could, say today, bump the GCS and Bigtable version numbers to say 1.5.0. Then in our May release of -cpp, we'd release the whole repo at version 1.5.0. That would put the whole repo, and Bigtable and GCS, at version 1.5.0.

Let me know what I'm misunderstanding.

@coryan coryan self-assigned this Apr 8, 2020
@coryan
Copy link
Contributor

coryan commented Apr 8, 2020

I think you are right, except for a couple of weird places, let me send a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants