Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel 7 "dangling symbolic link" flake #13444

Closed
dbolduc opened this issue Jan 13, 2024 · 1 comment
Closed

Bazel 7 "dangling symbolic link" flake #13444

dbolduc opened this issue Jan 13, 2024 · 1 comment
Labels
cpp: flake A test with false positives (failures that are not interesting) type: cleanup An internal cleanup or hygiene concern.

Comments

@dbolduc
Copy link
Member

dbolduc commented Jan 13, 2024

ERROR: /h/.cache/bazel/_bazel_root/eab0d61a99b6696edb3d2aff87b585e8/external/io_opentelemetry_cpp/sdk/src/common/BUILD:6:11: output 'external/io_opentelemetry_cpp/sdk/src/common/_virtual_includes/random/src/common/random.h' is a dangling symbolic link
ERROR: /h/.cache/bazel/_bazel_root/eab0d61a99b6696edb3d2aff87b585e8/external/io_opentelemetry_cpp/sdk/src/trace/BUILD:6:11: output 'external/io_opentelemetry_cpp/sdk/src/trace/_virtual_includes/trace/src/trace/span.h' is a dangling symbolic link
...etc...
ERROR: /h/.cache/bazel/_bazel_root/eab0d61a99b6696edb3d2aff87b585e8/external/io_opentelemetry_cpp/api/BUILD:13:11: Symlinking virtual headers for api failed: not all outputs were created or valid
ERROR: /h/.cache/bazel/_bazel_root/eab0d61a99b6696edb3d2aff87b585e8/external/io_opentelemetry_cpp/sdk/BUILD:6:11: Symlinking virtual headers for headers failed: not all outputs were created or valid

We only start seeing this flake when we upgrade to Bazel 7, which comes with "Build without bytes" enabled. This other issue seems related: bazelbuild/bazel#19143

In the 4 or 5 times we have seen the flake, the failure has always been with the @io_opentelemetry_cpp repo. I do not know what makes it special. My guess is their use of include_prefix, e.g.:

https://github.com/open-telemetry/opentelemetry-cpp/blob/c4f39f2be8109fd1a3e047677c09cf47954b92db/sdk/src/trace/BUILD#L10

@dbolduc dbolduc added type: cleanup An internal cleanup or hygiene concern. cpp: flake A test with false positives (failures that are not interesting) labels Jan 13, 2024
@dbolduc
Copy link
Member Author

dbolduc commented Feb 8, 2024

There is an upstream bug: bazelbuild/bazel#20886

We reverted our bazel version to avoid this issue. Let's just close this bug.

@dbolduc dbolduc closed this as completed Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp: flake A test with false positives (failures that are not interesting) type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

No branches or pull requests

1 participant