diff --git a/google/cloud/spanner/client.h b/google/cloud/spanner/client.h index 0378f83961f71..ccfcfccd8a5d5 100644 --- a/google/cloud/spanner/client.h +++ b/google/cloud/spanner/client.h @@ -961,8 +961,8 @@ std::shared_ptr MakeConnection(spanner::Database const& db, * The returned connection object should not be used directly, rather it should * be given to a `Client` instance, and methods should be invoked on `Client`. * - * @note Prefer using the `MakeConnection()` overload that accepts - * `google::cloud::Options`. + * @deprecated Please use the `MakeConnection()` overload that accepts + * `google::cloud::Options` instead. * * @see `Connection` * @@ -979,8 +979,8 @@ std::shared_ptr MakeConnection( /** * @copydoc MakeConnection(Database const&, ConnectionOptions const&, SessionPoolOptions) * - * @note Prefer using the `MakeConnection()` overload that accepts - * `google::cloud::Options`. + * @deprecated Please use the `MakeConnection()` overload that accepts + * `google::cloud::Options` instead. * * @param retry_policy override the default `RetryPolicy`, controls how long * the returned `Connection` object retries requests on transient diff --git a/google/cloud/spanner/internal/defaults.cc b/google/cloud/spanner/internal/defaults.cc index 9691a982bd1c5..3b95accd0857a 100644 --- a/google/cloud/spanner/internal/defaults.cc +++ b/google/cloud/spanner/internal/defaults.cc @@ -73,7 +73,7 @@ Options DefaultOptions(Options opts) { } } - // Sets Spanner-specific options from session_pool_options.h + // Sets Spanner-specific session-pool options. auto& num_channels = opts.lookup(); num_channels = (std::max)(num_channels, 1); if (!opts.has()) { diff --git a/google/cloud/spanner/internal/defaults_test.cc b/google/cloud/spanner/internal/defaults_test.cc index 2b7443dd61149..7c38e62245e39 100644 --- a/google/cloud/spanner/internal/defaults_test.cc +++ b/google/cloud/spanner/internal/defaults_test.cc @@ -15,7 +15,6 @@ #include "google/cloud/spanner/internal/defaults.h" #include "google/cloud/spanner/internal/session_pool.h" #include "google/cloud/spanner/options.h" -#include "google/cloud/spanner/session_pool_options.h" #include "google/cloud/common_options.h" #include "google/cloud/grpc_options.h" #include "google/cloud/internal/compiler_info.h" diff --git a/google/cloud/spanner/internal/metadata_spanner_stub_test.cc b/google/cloud/spanner/internal/metadata_spanner_stub_test.cc index 154af8758b260..6e3e7a622e6b1 100644 --- a/google/cloud/spanner/internal/metadata_spanner_stub_test.cc +++ b/google/cloud/spanner/internal/metadata_spanner_stub_test.cc @@ -15,6 +15,7 @@ #include "google/cloud/spanner/internal/metadata_spanner_stub.h" #include "google/cloud/spanner/database.h" #include "google/cloud/spanner/testing/mock_spanner_stub.h" +#include "google/cloud/common_options.h" #include "google/cloud/internal/api_client_header.h" #include "google/cloud/testing_util/status_matchers.h" #include "google/cloud/testing_util/validate_metadata.h" diff --git a/google/cloud/spanner/internal/session_pool.h b/google/cloud/spanner/internal/session_pool.h index f4f1f2302b07c..9bb6f306f812a 100644 --- a/google/cloud/spanner/internal/session_pool.h +++ b/google/cloud/spanner/internal/session_pool.h @@ -21,7 +21,6 @@ #include "google/cloud/spanner/internal/session.h" #include "google/cloud/spanner/internal/spanner_stub.h" #include "google/cloud/spanner/retry_policy.h" -#include "google/cloud/spanner/session_pool_options.h" #include "google/cloud/spanner/version.h" #include "google/cloud/backoff_policy.h" #include "google/cloud/completion_queue.h" diff --git a/google/cloud/spanner/internal/spanner_stub.h b/google/cloud/spanner/internal/spanner_stub.h index f587ea74e5f75..8009f220c1ee8 100644 --- a/google/cloud/spanner/internal/spanner_stub.h +++ b/google/cloud/spanner/internal/spanner_stub.h @@ -15,7 +15,6 @@ #ifndef GOOGLE_CLOUD_CPP_GOOGLE_CLOUD_SPANNER_INTERNAL_SPANNER_STUB_H #define GOOGLE_CLOUD_CPP_GOOGLE_CLOUD_SPANNER_INTERNAL_SPANNER_STUB_H -#include "google/cloud/spanner/connection_options.h" #include "google/cloud/spanner/database.h" #include "google/cloud/spanner/version.h" #include "google/cloud/completion_queue.h" diff --git a/google/cloud/spanner/samples/samples.cc b/google/cloud/spanner/samples/samples.cc index c423a88a0e02c..0fd95c9fe6909 100644 --- a/google/cloud/spanner/samples/samples.cc +++ b/google/cloud/spanner/samples/samples.cc @@ -21,7 +21,6 @@ #include "google/cloud/spanner/admin/instance_admin_options.h" #include "google/cloud/spanner/backoff_policy.h" #include "google/cloud/spanner/backup.h" -#include "google/cloud/spanner/connection_options.h" #include "google/cloud/spanner/create_instance_request_builder.h" #include "google/cloud/spanner/row.h" #include "google/cloud/spanner/testing/debug_log.h" // TODO(#4758): remove