Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap target, request for request, target in secure_authorized_channel's argument order. #81

Merged
merged 2 commits into from
Nov 10, 2016
Merged

Swap target, request for request, target in secure_authorized_channel's argument order. #81

merged 2 commits into from
Nov 10, 2016

Conversation

theacodes
Copy link
Contributor

No description provided.

dhermes
dhermes approved these changes Nov 10, 2016
View reviewed changes
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Why?

@theacodes
Copy link
Contributor Author

@dhermes because the previous argument order just didn't flow logically to me, it was previously auth object, grpc object, auth object, grpc object, now it's auth object, auth object, grpc object, grpc object.

@theacodes theacodes merged commit 840b3ac into master Nov 10, 2016
@theacodes theacodes deleted the swap-grpc-arg-order branch November 10, 2016 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhermes dhermes dhermes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theacodes @dhermes