fix(deps): allow cachetools 5.0 for python 3.7+ #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdce8p
reviewed
Jan 13, 2022
setup.py
Outdated
Comment on lines
23
to
24
| 'cachetools>=2.0.0,<5.0; python_version < "3.7"', | ||
| 'cachetools>=2.0.0,<6.0; python_version >= "3.7"', |
There was a problem hiding this comment.
Suggested change
| 'cachetools>=2.0.0,<5.0; python_version < "3.7"', | |
| 'cachetools>=2.0.0,<6.0; python_version >= "3.7"', | |
| 'cachetools>=2.0.0,<6.0', |
That shouldn't be necessary. Pip can automatically resolve the compatible version. I.e. pip will choose <5.0 for Python 3.6.
There was a problem hiding this comment.
Ah sorry, I lost track of this PR. I've condensed this down to one pin as suggested.
22 tasks
busunkim96
requested review from
arithmetic1728,
silvolu and
a team
as code owners
arithmetic1728
approved these changes
Jan 20, 2022
arithmetic1728
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jan 20, 2022
🤖 I have created a release *beep* *boop* --- ## [2.4.0](v2.3.3...v2.4.0) (2022-01-20) ### Features * add 'py.typed' declaration ([#919](#919)) ([c993504](c993504)) * add api key support ([#826](#826)) ([3b15092](3b15092)) ### Bug Fixes * **deps:** allow cachetools 5.0 for python 3.7+ ([#937](#937)) ([1eae37d](1eae37d)) * fix the message format for metadata server exception ([#916](#916)) ([e756f08](e756f08)) ### Documentation * fix intersphinx link for 'requests-oauthlib' ([#921](#921)) ([967be4f](967be4f)) * note ValueError in `verify_oauth2_token` ([#928](#928)) ([82bc5f0](82bc5f0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #934.
Changes to cachetools listed in https://github.com/tkem/cachetools/blob/master/CHANGELOG.rst#v500-2021-12-21