Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow the AWS_DEFAULT_REGION environment variable #721

Merged
merged 4 commits into from
Mar 13, 2021
Merged

feat: allow the AWS_DEFAULT_REGION environment variable #721

merged 4 commits into from
Mar 13, 2021

Conversation

ScruffyProdigy
Copy link
Contributor

Amazon has this variable documented, and apparently people are trying to
use it, so we should support it

@ScruffyProdigy
feat: allow the AWS_DEFAULT_REGION environment variable
955ddc8 
Amazon has this variable documented, and apparently people are trying to 
use it, so we should support it
@ScruffyProdigy ScruffyProdigy requested a review from a team as a code owner March 11, 2021 23:18
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 11, 2021
bojeil-google
bojeil-google suggested changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@bojeil-google bojeil-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you need to run blacken to fix the linter errors.
You also need to update the functions descriptions, e.g. _get_region to mention that we also read AWS_DEFAULT_REGION.

tests/test_aws.py Outdated Show resolved Hide resolved
tests/test_aws.py Show resolved Hide resolved
bojeil-google
bojeil-google approved these changes Mar 12, 2021
View reviewed changes
Copy link
Contributor

@bojeil-google bojeil-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more thing. Can you update the descriptions to mention that we also support AWS_DEFAULT_REGION?
These places:

bojeil-google
bojeil-google approved these changes Mar 12, 2021
View reviewed changes
Copy link
Contributor

@bojeil-google bojeil-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making all the changes!

@busunkim96 busunkim96 added the automerge Merge the pull request once unit tests and other checks pass. label Mar 12, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 199da47 into googleapis:master Mar 13, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 13, 2021
@ScruffyProdigy ScruffyProdigy deleted the aws-default-region branch March 13, 2021 00:13
This was referenced Mar 17, 2021
Merged
Merged
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Merged
Closed
Closed
Closed
This was referenced Mar 17, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bojeil-google bojeil-google bojeil-google approved these changes

@busunkim96 busunkim96 busunkim96 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ScruffyProdigy @busunkim96 @bojeil-google