Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement async StaticCredentials using access tokens #1559

Merged
merged 18 commits into from
Jul 17, 2024
Merged

feat: implement async StaticCredentials using access tokens #1559

merged 18 commits into from
Jul 17, 2024

Conversation

ohmayr
Copy link
Contributor

@ohmayr ohmayr commented Jul 12, 2024 •
edited
Loading

This PR implements the following:

  • google.auth.aio.credentials.Credentials which is an abstract class for asynchronous credentials.
  • google.auth.aio.credentials.StaticCredentials to allow users to configure a valid access token.
  • google.auth.aio.credentials.AnonymousCredential for testing purposes.

@ohmayr ohmayr marked this pull request as ready for review July 15, 2024 17:13
@ohmayr ohmayr requested review from a team as code owners July 15, 2024 17:13
vchudnov-g
vchudnov-g reviewed Jul 15, 2024
View reviewed changes
google/auth/_credentials_base.py Outdated Show resolved Hide resolved
tests/oauth2/test_credentials_async.py Outdated Show resolved Hide resolved
tests/test_credentials_async.py Outdated Show resolved Hide resolved
tests/test_credentials_async.py Outdated Show resolved Hide resolved
@ohmayr ohmayr changed the title feat: implement async oauth2 credentials feat: implement async StaticCredentials using access tokens Jul 16, 2024
@ohmayr ohmayr force-pushed the implement-async-credentials branch from 1cea3f3 to 02991a8 Compare July 16, 2024 20:23
@clundin25
Copy link
Contributor

A few tiny nits, but this LGTM.

@ohmayr ohmayr merged commit dc17dfc into main Jul 17, 2024
16 checks passed
@ohmayr ohmayr deleted the implement-async-credentials branch July 17, 2024 20:43
@release-please release-please bot mentioned this pull request Jul 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vchudnov-g vchudnov-g vchudnov-g left review comments

@clundin25 clundin25 clundin25 approved these changes

Assignees

@vchudnov-g vchudnov-g

@clundin25 clundin25

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ohmayr @clundin25 @vchudnov-g