Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement pluggable auth interactive mode #1131

Merged
merged 45 commits into from
Sep 28, 2022
Merged

feat: implement pluggable auth interactive mode #1131

merged 45 commits into from
Sep 28, 2022

Conversation

BigTailWolf
Copy link
Contributor

@BigTailWolf BigTailWolf commented Aug 31, 2022 •
edited
Loading

For interactive mode:

  1. Always using output to read the result.
  2. Make "expiration_time" optional for all mode.
  3. Implement interactive mode run executable
  4. Implement revoke() function.
  5. Refactor tests

@BigTailWolf BigTailWolf added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 31, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 31, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 31, 2022
@BigTailWolf BigTailWolf requested a review from lsirac August 31, 2022 17:36
@BigTailWolf BigTailWolf assigned BigTailWolf and unassigned lsirac Aug 31, 2022
@BigTailWolf BigTailWolf requested a review from aeitzman August 31, 2022 17:46
aeitzman
aeitzman requested changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@aeitzman aeitzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass

google/auth/pluggable.py Outdated Show resolved Hide resolved
google/auth/pluggable.py Outdated Show resolved Hide resolved
google/auth/pluggable.py Outdated Show resolved Hide resolved
google/auth/pluggable.py Outdated Show resolved Hide resolved
google/auth/pluggable.py Outdated Show resolved Hide resolved
google/auth/pluggable.py Outdated Show resolved Hide resolved
lsirac
lsirac reviewed Aug 31, 2022
View reviewed changes
google/auth/pluggable.py Show resolved Hide resolved
google/auth/pluggable.py Outdated Show resolved Hide resolved
google/auth/pluggable.py Outdated Show resolved Hide resolved
google/auth/pluggable.py Outdated Show resolved Hide resolved
google/auth/pluggable.py Outdated Show resolved Hide resolved
@lsirac lsirac added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 1, 2022
aeitzman
aeitzman requested changes Sep 6, 2022
View reviewed changes
google/auth/pluggable.py Outdated Show resolved Hide resolved
google/auth/pluggable.py Outdated Show resolved Hide resolved
google/auth/pluggable.py Outdated Show resolved Hide resolved
google/auth/pluggable.py Outdated Show resolved Hide resolved
google/auth/pluggable.py Show resolved Hide resolved
sai-sunder-s
sai-sunder-s reviewed Sep 6, 2022
View reviewed changes
google/auth/pluggable.py Outdated Show resolved Hide resolved
google/auth/pluggable.py Outdated Show resolved Hide resolved
google/auth/pluggable.py Outdated Show resolved Hide resolved
@BigTailWolf BigTailWolf added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 6, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 6, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 6, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 22, 2022
@BigTailWolf BigTailWolf added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 22, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 22, 2022
clundin25 and others added 3 commits September 22, 2022 23:38
@clundin25 @BigTailWolf
feat: Retry behavior (googleapis#1113)
06fff40 
* feat: Retry behavior

* Introduce `retryable` property to auth library exceptions. This can be
  used to determine if an exception should be retried.
* Introduce `should_retry` parameter to token endpoints. If set to `False`
  the auth library will not retry failed requests. If set to `True` the
  auth library will retry failed requests. The default value is `True`
  to maintain existing behavior.
* Expanded list of HTTP Status codes that will be retried.
* Modified retry behavior to use exponential backoff.
* Increased default retry attempts from 2 to 3.
@BigTailWolf
Revert "feat: Retry behavior (googleapis#1113)"
b4a1ae6 
This reverts commit 06fff40.
@BigTailWolf
Merge branch 'main' into b237591436
4950562
@BigTailWolf BigTailWolf added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 22, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 22, 2022
@BigTailWolf BigTailWolf added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 23, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 23, 2022
@BigTailWolf BigTailWolf added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 26, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 26, 2022
@BigTailWolf BigTailWolf added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 27, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 27, 2022
@BigTailWolf BigTailWolf added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 27, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 27, 2022
@BigTailWolf BigTailWolf added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 27, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 27, 2022
@BigTailWolf BigTailWolf merged commit 44a189f into googleapis:main Sep 28, 2022
@BigTailWolf BigTailWolf deleted the b237591436 branch September 28, 2022 17:29
@release-please release-please bot mentioned this pull request Sep 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeitzman aeitzman aeitzman approved these changes

@lsirac lsirac lsirac approved these changes

@sai-sunder-s sai-sunder-s sai-sunder-s approved these changes

@arithmetic1728 arithmetic1728 Awaiting requested review from arithmetic1728

Assignees

@BigTailWolf BigTailWolf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@BigTailWolf @sai-sunder-s @aeitzman @lsirac @yoshi-kokoro @clundin25