New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify Sign Blob works outside GDU #589

Open

bshaffer opened this issue Nov 19, 2024 · 1 comment

Contributor

bshaffer commented Nov 19, 2024

Ensure that the methods in SignBlobInterface, Iam, and IamSignerTrait work outside the GDU

The text was updated successfully, but these errors were encountered:

Contributor Author

bshaffer commented Nov 19, 2024

signBlob is implemented in two different places:

In the ServiceAccountSignerTrait - the signing key is used to sign the blob directly. No network call is made
In the IamSignerTrait - The Iam helper class is used to make an API call to the IAM API in order to sign the blob.

In the case of (1), no network call is made (it's already Universe Domain agnostic).
In the case of (2), the IAM object is created with the configured universe domain. Because the universe domain is already supported in Iam::signBlob, this is supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment