Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features to remove for V2 #582

Open
bshaffer opened this issue Oct 5, 2024 · 0 comments
Open

Features to remove for V2 #582

bshaffer opened this issue Oct 5, 2024 · 0 comments
Labels

Comments

@bshaffer
Copy link
Contributor

bshaffer commented Oct 5, 2024

This is a list of items we want to change / remove in the next major release

  • Remove all instances of getLastReceivedToken
  • Remove all instances of tokenCallback
  • The constructor of IAM should not contain $httpHandler - this should be passed in at runtime
  • Consider removing IAM in favor of using IamTrait in the credentials which use it.
  • Remove FetchAuthTokenCache in favor of CacheTrait
  • Consider adding $headers as second argument to FetchAuthTokenIterface::fetchAuthToken, or consolidate everything to use updateMetadata
  • Consider consolidating FetchAuthTokenInterface, UpdateMetadataInterface, ProjectIdProviderInterface, GetQuotaProjectInterface, and GetUniverseDomainInterface into a CredentialInterface.
  • Consider removing HttpClientCache, as $httpHandler can already be passed in everywhere
  • Remove Guzzle6HttpHandler
  • Remove IAMCredentials
  • Move to Firebase JWT for token validation (feat: use Firebase JWT for token verification #554)
@bshaffer bshaffer added the v2 label Oct 5, 2024
@bshaffer bshaffer changed the title Features to deprecate for V2 Features to remove for V2 Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant