docs: document proxy behavior and verify with a test #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
ofrobots
approved these changes
Dec 27, 2017
test/test.transporters.ts
Outdated
| const url = 'http://example.com/fake'; | ||
| const result = await transporter.request({url}); | ||
| assert.equal(result.status, 200); | ||
| process.env['http_proxy'] = undefined; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
test/test.transporters.ts
Outdated
| @@ -98,4 +98,42 @@ describe('Transporters', () => { | |||
| done(); | |||
| }); | |||
| }); | |||
|
|
|||
| it('should use the http proxy if one is configured', async () => { | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
ofrobots
pushed a commit
that referenced
this pull request
Jan 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The axios npm module supports setting an HTTP or HTTPS proxy via the http_proxy and https_proxy environment variables. It also happens to be undocumented, which I didn't figure out until writing my own implementation 😂
Here I'm just adding a few tests, and updating our docs. I will follow up with a PR against the axios docs to save others from my fate.
Addresses #65.