feat: Open More Endpoints for Customization #1721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-fenster
approved these changes
Jan 26, 2024
lsirac
reviewed
Jan 26, 2024
| * @example | ||
| * 'https://sts.googleapis.com/v1/token' | ||
| */ | ||
| tokenURL?: string | URL; |
There was a problem hiding this comment.
Any reason to expose this? We don't in Java.
There was a problem hiding this comment.
Opened a PR to revert for consistency: #1744
| private static readonly GOOGLE_OAUTH2_FEDERATED_SIGNON_PEM_CERTS_URL_ = | ||
| 'https://www.googleapis.com/oauth2/v1/certs'; | ||
| this.endpoints = { | ||
| tokenInfoUrl: `https://oauth2.${this.universeDomain}/tokeninfo`, |
There was a problem hiding this comment.
I am not sure if these are in scope?
There was a problem hiding this comment.
Opened a PR to revert: #1744
This was referenced Jun 7, 2024
This was referenced Jul 26, 2024
This was referenced Aug 3, 2024
This was referenced Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes AL-3
🦕