You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We now depend on guava-jdk5:13.0. In both google-cloud-java and gax-java we instead depend on standard guava (version 19 and 18 respectively).
Is there any reason for depending on guava-jdk5? If not excluded (as we do in google-cloud-java), this just results in a bunch of duplicated classes in all projects that use standard guava. /cc @anthmgoogle@garrettjonesgoogle
The text was updated successfully, but these errors were encountered:
This is still an issue. 1.23.0 depends on guava-jdk5:17.0 and it causes dependency conflicts with dropwizard 1.2.0 which uses the standard guava com.google.guava:guava:23.1-jre
Unfortunately, the method Throwables.throwIfUnchecked(e) doesn't exist in guava-jdk5:17.0 causing failures in tests.
Could you guys please take a look. The Google client library is the recommended way for authenticating with firebase and we don't want to switch to the legacy API because of this problem.
For readers, this will fix the issue if you are using Gradle
compile (group: 'com.google.api-client', name: 'google-api-client', version: '1.23.0') {
// excludes all guava packages including com.google.guava:guava-jdk5:17.0 which gets pulled in
exclude group: 'com.google.guava'
}
We now depend on
guava-jdk5:13.0
. In bothgoogle-cloud-java
andgax-java
we instead depend on standardguava
(version 19 and 18 respectively).Is there any reason for depending on
guava-jdk5
? If not excluded (as we do ingoogle-cloud-java
), this just results in a bunch of duplicated classes in all projects that use standardguava
. /cc @anthmgoogle @garrettjonesgoogleThe text was updated successfully, but these errors were encountered: