Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using guava instead of guava-jdk5 dependency #68

Closed
mziccard opened this issue Sep 23, 2016 · 4 comments
Closed

Using guava instead of guava-jdk5 dependency #68

mziccard opened this issue Sep 23, 2016 · 4 comments
Assignees
Labels
🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@mziccard
Copy link
Contributor

We now depend on guava-jdk5:13.0. In both google-cloud-java and gax-java we instead depend on standard guava (version 19 and 18 respectively).

Is there any reason for depending on guava-jdk5? If not excluded (as we do in google-cloud-java), this just results in a bunch of duplicated classes in all projects that use standard guava. /cc @anthmgoogle @garrettjonesgoogle

@mziccard
Copy link
Contributor Author

This was fixed with #69

@suvodeep-pyne
Copy link

suvodeep-pyne commented Nov 15, 2017

This is still an issue.
1.23.0 depends on guava-jdk5:17.0 and it causes dependency conflicts with dropwizard 1.2.0 which uses the standard guava com.google.guava:guava:23.1-jre

Unfortunately, the method Throwables.throwIfUnchecked(e) doesn't exist in guava-jdk5:17.0 causing failures in tests.

Could you guys please take a look. The Google client library is the recommended way for authenticating with firebase and we don't want to switch to the legacy API because of this problem.

For readers, this will fix the issue if you are using Gradle

compile (group: 'com.google.api-client', name: 'google-api-client', version: '1.23.0') {
  // excludes all guava packages including com.google.guava:guava-jdk5:17.0 which gets pulled in
  exclude group: 'com.google.guava'
}

@martinbonnin
Copy link

martinbonnin commented Dec 12, 2017

Same problem here with

implementation (group: 'com.google.apis', name:'google-api-services-androidpublisher', version:'v2-rev47-1.23.0') 
implementation (group: 'com.google.cloud', name: 'google-cloud-storage', version: '1.12.0')

I had to exclude group: 'com.google.guava' as @suvodeep-pyne mentioned

@arunsankar8
Copy link

@suvodeep-pyne Thanks man, It worked

@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Development

No branches or pull requests

5 participants