Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update accounts.google.com authorization URI #2275

Merged
merged 3 commits into from
Oct 27, 2022

Conversation

niallkennedy
Copy link
Contributor

Update Google authorization URI to match authorization_endpoint value provided in the accounts.google.com OIDC Discovery doc.

Update Google authorization URI to match authorization_endpoint value provided in OIDC Discovery doc [1].

[1] https://accounts.google.com/.well-known/openid-configuration
@niallkennedy niallkennedy requested a review from a team as a code owner June 8, 2022 22:42
update tests to include latest authorization URI from accounts.google.com OIDC Discovery authorization_endpoint value
@vishwarajanand vishwarajanand enabled auto-merge (squash) October 27, 2022 16:21
@vishwarajanand vishwarajanand merged commit b2624d2 into googleapis:main Oct 27, 2022
@niallkennedy niallkennedy deleted the patch-1 branch October 27, 2022 17:28
@ziemkowski
Copy link

ziemkowski commented Dec 29, 2022

In case anybody stumbles upon this PR while researching an issue with some Google OAuth requests no longer returning a refresh_token via this PHP SDK, be aware that this change breaks old code that uses setApprovalPrompt('force') instead of the newer setPrompt('consent') method, as this endpoint does not support the legacy approval prompt parameter.

Changing your code to use the newer method should fix the issue and return refresh_token when also marked as offline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants