Modules "net" and "tls" not found when running webpack under sheets API directory

[cwysong85]

Environment details

• OS: Windows 10 Pro v10.0.17134
• Node.js version: 10.16.0
• npm version: 6.9.0
• googleapis version: 40.0.0

Steps to reproduce

1. cd src/apis/sheets
2. npm install
3. npm run webpack

If you are running the environment versions above, the webpack compilation should error out.

λ npm run webpack

> @google/[email protected] webpack C:\Users\corey\google-api-nodejs-client\src\apis\sheets
> webpack

Hash: 4f6e54b109b233b15a5a
Version: webpack 4.33.0
Time: 3324ms
Built at: 06/12/2019 11:21:08 AM
 3 assets
Entrypoint main = sheets.min.js
  [3] (webpack)/buildin/global.js 472 bytes {0} [built]
 [39] crypto (ignored) 15 bytes {0} [built]
 [87] ./index.ts 1.06 KiB {0} [built]
 [95] util (ignored) 15 bytes {0} [built]
 [97] util (ignored) 15 bytes {0} [built]
[106] (webpack)/buildin/module.js 497 bytes {0} [built]
[177] ./v4.ts 24.4 KiB {0} [built]
    + 171 hidden modules

ERROR in ./node_modules/https-proxy-agent/index.js
Module not found: Error: Can't resolve 'net' in 'C:\Users\corey\google-api-nodejs-client\src\apis\sheets\node_modules\https-proxy-agent'
 @ ./node_modules/https-proxy-agent/index.js 5:10-24
 @ ./node_modules/gaxios/build/src/gaxios.js
 @ ./node_modules/gaxios/build/src/index.js
 @ ./node_modules/google-auth-library/build/src/transporters.js
 @ ./node_modules/google-auth-library/build/src/index.js
 @ ./node_modules/googleapis-common/build/src/index.js
 @ ./index.ts

ERROR in ./node_modules/https-proxy-agent/index.js
Module not found: Error: Can't resolve 'tls' in 'C:\Users\corey\google-api-nodejs-client\src\apis\sheets\node_modules\https-proxy-agent'
 @ ./node_modules/https-proxy-agent/index.js 6:10-24
 @ ./node_modules/gaxios/build/src/gaxios.js
 @ ./node_modules/gaxios/build/src/index.js
 @ ./node_modules/google-auth-library/build/src/transporters.js
 @ ./node_modules/google-auth-library/build/src/index.js
 @ ./node_modules/googleapis-common/build/src/index.js
 @ ./index.ts
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! @google/[email protected] webpack: `webpack`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the @google/[email protected] webpack script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\corey\AppData\Roaming\npm-cache\_logs\2019-06-12T15_21_08_768Z-debug.log

Steps to fix

1. edit webpack.config.js
2. Add net: 'empty' and tls: 'empty' to the node section:

  node: {
    child_process: 'empty',
    fs: 'empty',
    crypto: 'empty',
    net: 'empty',
    tls: 'empty'
  },

3. npm run webpack should now work.

Making sure to follow these steps will guarantee the quickest resolution possible.

Thanks!

[bcoe]

@cwysong85 I'm glad you've found a work around 👍 we're in the process of looking into fixing this upstream (so that the workaround could be avoided).

I've also created a tracking ticket to add integration tests (to prevent these sorts of regressions).

[alexander-fenster]

So the fun thing is that I can't repro this on Linux and you're apparently doing this on Windows. I wonder if it might the reason why the regular expressions fail in webpack.config.js tests (the https-proxy-agent should be ignored alltogether and replaced with a null-module).

I'll try to repro on Windows machine, and if it reproduces, I'll fix the config. For now, @cwysong85, would it be possible for you to try running npm run webpack on Linux or Mac and let us know if it works for you there?

[ghost]

thank man, very help

[watermirror1107]

webpack.config.js this file add a options "target:'node'"