feat: expose experimental universe-related options #2264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the first step in plumbing a universe option into clients by first exposing it as part of the option package. It propagates that onto the internal.DialSettings which receives the applied options, but no further.
quartzmo
reviewed
Nov 30, 2023
quartzmo
approved these changes
Nov 30, 2023
shollyman
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Dec 5, 2023
🤖 I have created a release *beep* *boop* --- ## [0.153.0](https://togithub.com/googleapis/google-api-go-client/compare/v0.152.0...v0.153.0) (2023-12-05) ### Features * **all:** Auto-regenerate discovery clients ([#2276](https://togithub.com/googleapis/google-api-go-client/issues/2276)) ([510f0f9](https://togithub.com/googleapis/google-api-go-client/commit/510f0f92034370f5164063af521c7a383b823b3e)) * **all:** Auto-regenerate discovery clients ([#2279](https://togithub.com/googleapis/google-api-go-client/issues/2279)) ([d07fe32](https://togithub.com/googleapis/google-api-go-client/commit/d07fe323e887d43e0b3a4bdd9c9c9f9c62ea34af)) * **all:** Auto-regenerate discovery clients ([#2280](https://togithub.com/googleapis/google-api-go-client/issues/2280)) ([e8e2895](https://togithub.com/googleapis/google-api-go-client/commit/e8e2895d6965b0304bfe7b9a964302275b41b09f)) * **all:** Auto-regenerate discovery clients ([#2283](https://togithub.com/googleapis/google-api-go-client/issues/2283)) ([bdc87de](https://togithub.com/googleapis/google-api-go-client/commit/bdc87de2cbcd83567983bc12cf0f8638ff104f35)) * **all:** Auto-regenerate discovery clients ([#2286](https://togithub.com/googleapis/google-api-go-client/issues/2286)) ([7897739](https://togithub.com/googleapis/google-api-go-client/commit/789773971f9eeacdeb0f6f0c13c9b04e3269f951)) * **all:** Auto-regenerate discovery clients ([#2287](https://togithub.com/googleapis/google-api-go-client/issues/2287)) ([4148872](https://togithub.com/googleapis/google-api-go-client/commit/414887212d8b6b2bca29e0d291fafaf84e142b07)) * **all:** Auto-regenerate discovery clients ([#2290](https://togithub.com/googleapis/google-api-go-client/issues/2290)) ([9f55397](https://togithub.com/googleapis/google-api-go-client/commit/9f55397fcea161b32ba14b5f6bb25f85abda0aa3)) * **all:** Auto-regenerate discovery clients ([#2291](https://togithub.com/googleapis/google-api-go-client/issues/2291)) ([0a6ebe4](https://togithub.com/googleapis/google-api-go-client/commit/0a6ebe42419ee01f95ff02cd51e041d4fe7a0678)) * Expose experimental universe-related options ([#2264](https://togithub.com/googleapis/google-api-go-client/issues/2264)) ([e648a9d](https://togithub.com/googleapis/google-api-go-client/commit/e648a9d2cc0ed492ea50a1d312ab17c812a2272c)) * Update workloadmanager api manually ([#2282](https://togithub.com/googleapis/google-api-go-client/issues/2282)) ([4aaad57](https://togithub.com/googleapis/google-api-go-client/commit/4aaad573b05144eac4fcf57753303b3b82393f02)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
quartzmo
added a commit
to quartzmo/google-api-go-client
that referenced
this pull request
Dec 18, 2023
* Add DefaultEndpointTemplate to internal/settings.go * Deprecate internaloption.WithDefaultEndpoint refs: googleapis#2264
quartzmo
added a commit
to quartzmo/google-api-go-client
that referenced
this pull request
Dec 18, 2023
* Add DefaultEndpointTemplate to internal/settings.go * Deprecate internaloption.WithDefaultEndpoint refs: googleapis#2264
quartzmo
added a commit
to quartzmo/google-api-go-client
that referenced
this pull request
Dec 18, 2023
* Add DefaultEndpointTemplate to internal/settings.go * Deprecate internaloption.WithDefaultEndpoint refs: googleapis#2264
quartzmo
added a commit
that referenced
this pull request
Dec 19, 2023
* Add DefaultEndpointTemplate to internal/settings.go * Deprecate internaloption.WithDefaultEndpoint refs: #2264
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the first step in plumbing a universe option into clients
by first exposing it as part of the option package.
It exposes a
WithUniverse(string)as a public option, andWithDefaultUniverse(string)as an internal option that can be used by generated clients. It also augments existing
tests.
It does not yet include any behavioral changes.