Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update grpc-js to 0.6.18 to fix retry issues in nodejs-pubsub (and elsewhere?) #727

Closed
feywind opened this issue Feb 25, 2020 · 2 comments
Closed

Update grpc-js to 0.6.18 to fix retry issues in nodejs-pubsub (and elsewhere?) #727

feywind opened this issue Feb 25, 2020 · 2 comments
Assignees
@alexander-fenster
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@feywind
Copy link
Contributor

feywind commented Feb 25, 2020

The recent fixes to grpc-js seem to have fixed some issues, and I'd like to pull those in as a minimum version here to get it into upstream clients.

googleapis/nodejs-pubsub#890

PR coming shortly.
@feywind feywind added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Feb 25, 2020
@feywind feywind mentioned this issue Feb 25, 2020
Merged
@feywind
Copy link
Contributor Author

feywind commented Feb 25, 2020

@murgatroid99 Does it look okay to go ahead and update the versions?

@feywind feywind mentioned this issue Feb 26, 2020
Merged
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels May 25, 2020
@alexander-fenster alexander-fenster self-assigned this Jun 2, 2020
@alexander-fenster
Copy link
Contributor

This is out of date and should be closed. We use @grpc/grpc-js v1.0.0+.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexander-fenster alexander-fenster

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexander-fenster @yoshi-automation @feywind