Sometimes we don't return GoogleErrors

[sofisl]

While investigating error handling from this doc: https://docs.google.com/document/d/1UOj7Eo3xdMK1pxtt-cw3z0mAXEHnx1icb6XsADSthiU/edit?resourcekey=0-Pns_E0nx5cMD_7l6QgtX6g&tab=t.0, I realized we don't return errors typed GoogleError through grpc. Importantly, this line:

gax-nodejs/gax/src/call.ts

Line 128 in 2d0cb03

rejectCallback(GoogleError.parseGRPCStatusDetails(err));

doesn't actually make this into a GoogleError (it actually expects a GoogleError - see

gax-nodejs/gax/src/googleError.ts

Line 35 in 2d0cb03

static parseGRPCStatusDetails(err: GoogleError): GoogleError {

). We should create a new error, like so:

gax-nodejs/gax/src/googleError.ts

Line 89 in 2d0cb03

const error = Object.assign(