feat: expose uuid for autopopulation of request_id #1542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gax/package.json
Outdated
| @@ -13,18 +13,20 @@ | |||
| "@grpc/grpc-js": "~1.9.6", | |||
| "@grpc/proto-loader": "^0.7.0", | |||
| "@types/long": "^4.0.0", | |||
| "@types/uuid": "^9.0.7", | |||
There was a problem hiding this comment.
This should go to devDependencies unless there is a reason not to. @types/long is an exception, it's a dependency of the generated .d.ts files so we must list it as if it is a runtime dependency. Other types go to devDeps.
gax/src/util.ts
Outdated
| @@ -13,6 +13,8 @@ | |||
| * See the License for the specific language governing permissions and | |||
| * limitations under the License. | |||
| */ | |||
| // eslint-disable-next-line node/no-extraneous-import | |||
There was a problem hiding this comment.
it's not extraneous?
|
I believe you should also reexport it from |
alexander-fenster
approved these changes
Jan 18, 2024
Merged
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jan 19, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>4.2.0</summary> ## [4.2.0](https://togithub.com/googleapis/gax-nodejs/compare/v4.1.0...v4.2.0) (2024-01-18) ### Features * expose uuid for autopopulation of request_id ([#1542](https://togithub.com/googleapis/gax-nodejs/issues/1542)) ([6c66e22](https://togithub.com/googleapis/gax-nodejs/commit/6c66e224919e1bb7a8c044927e1c70f9d32bddb4)) </details> --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically, we're not adding a dependency since we depend on uuid through retry-request --> teeny-request --> uuid. This will allow this work: googleapis/gapic-generator-typescript#1511 to be executed in Node and alternate environments (without having to depend on importing crypto)