Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to echo back the x-goog-api-version header so that AIP-4236 can be tested #1493

Closed
parthea opened this issue Apr 8, 2024 · 1 comment · Fixed by #1501
Closed

Add support to echo back the x-goog-api-version header so that AIP-4236 can be tested #1493

parthea opened this issue Apr 8, 2024 · 1 comment · Fixed by #1501
Assignees
@parthea
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@parthea
Copy link
Contributor

parthea commented Apr 8, 2024

See aip-dev/google.aip.dev#1331 for AIP 4236 and review feedback from #1484

the showcase server "echos" back the metadata/headers it was sent as trailing metadata/response headers so that the generator integration tests can capture them and assert what it sent was expected
@parthea parthea added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Apr 8, 2024
@parthea parthea mentioned this issue Apr 8, 2024
Merged
@parthea parthea added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Apr 8, 2024
@vchudnov-g
Copy link
Contributor

Happy to help with this. I am doing some "echoing back" changes in some git branches to test various things. And this will also tie in with the Showcase testing infrastructure work.

@parthea parthea self-assigned this Apr 15, 2024
@parthea parthea mentioned this issue Apr 15, 2024
Merged
@vchudnov-g vchudnov-g mentioned this issue Apr 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parthea parthea

Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add ability to echo request headers in trailing metadata googleapis/gapic-showcase
2 participants
@parthea @vchudnov-g