Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a bazel integration test #1476

Closed
parthea opened this issue Mar 21, 2024 · 1 comment · Fixed by #1479
Closed

Add a bazel integration test #1476

parthea opened this issue Mar 21, 2024 · 1 comment · Fixed by #1479
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@parthea
Copy link
Contributor

parthea commented Mar 21, 2024

An integration test should be added to ensure a successful build for the following bazel target

proto_library(
name = "showcase_proto",
srcs = [":compliance.proto", ":echo.proto", ":identity.proto", ":messaging.proto", ":sequence.proto", ":testing.proto" ],
deps = [
"@com_google_googleapis//google/api:annotations_proto",
"@com_google_googleapis//google/api:client_proto",
"@com_google_googleapis//google/api:field_behavior_proto",
"@com_google_googleapis//google/api:resource_proto",
"@com_google_googleapis//google/api:routing_proto",
"@com_google_googleapis//google/longrunning:operations_proto",
"@com_google_googleapis//google/rpc:status_proto",
"@com_google_googleapis//google/rpc:error_details_proto",
"@com_google_protobuf//:duration_proto",
"@com_google_protobuf//:empty_proto",
"@com_google_protobuf//:field_mask_proto",
"@com_google_protobuf//:timestamp_proto",
]
)

See #1475 where the bazel target could not be built at HEAD

@parthea parthea added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Mar 21, 2024
@noahdietz
Copy link
Collaborator

lmk if you want me to take this, otherwise, assign it to yourself if you are adding it already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants