Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpJson Mixins RPCs (Locations & IAM) Not Supported #1299

Closed
Tracked by #1439
lqiu96 opened this issue Apr 18, 2023 · 3 comments · Fixed by #1300 or googleapis/sdk-platform-java#1656
Closed
Tracked by #1439

HttpJson Mixins RPCs (Locations & IAM) Not Supported #1299

lqiu96 opened this issue Apr 18, 2023 · 3 comments · Fixed by #1300 or googleapis/sdk-platform-java#1656
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@lqiu96
Copy link
Contributor

lqiu96 commented Apr 18, 2023

In the genrest.go code to generate the handlers:

func RegisterHandlers(router *gmux.Router, backend *services.Backend) {

there is no code to generate the mixins RPCs handlers. When calling this via Java, we are seeing a 400 Bad Request:

Client Recieves:

Caused by: com.google.api.client.http.HttpResponseException: 400 Bad Request
GET http://localhost:7469/v1beta1/projects/showcase/locations/us-central1
{"error":{"code":400,"message":"unrecognized request: GET \"/v1beta1/projects/showcase/locations/us-central1\"","details":null,"Body":"","Header":null,"Errors":null}}
	at com.google.api.client.http.HttpResponseException$Builder.build(HttpResponseException.java:293)
	at com.google.api.client.http.HttpRequest.execute(HttpRequest.java:1118)
	at com.google.api.gax.httpjson.HttpRequestRunnable.run(HttpRequestRunnable.java:118)

Server sends:

unrecognized request: GET "/v1beta1/projects/showcase/locations/us-central1"

Possible Fix:

@lqiu96 lqiu96 added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Apr 18, 2023
@noahdietz noahdietz self-assigned this Apr 18, 2023
@noahdietz
Copy link
Collaborator

Looks like there was a TODO to add these and I didn't DO! I've got something started for this.

@lqiu96
Copy link
Contributor Author

lqiu96 commented Apr 19, 2023

Wow, thanks for being so quick with this @noahdietz! FYI, this change isn't blocking anything on Java-side yet so we're not in a rush with this. Thanks again for immediately jumping on this :)

@noahdietz
Copy link
Collaborator

No problem, it was easy and definitely necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
2 participants