Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: export showcase_v1beta1.yaml from BUILD.bazel to support external GAPIC generation #1223

Merged
merged 2 commits into from
Oct 24, 2022

Conversation

burkedavison
Copy link
Contributor

By exporting *.yaml from this BUILD file, gapic-generator-java repo will be able to directly reference the showcase_v1beta1.yaml when invoking its java_gapic_library target.

java_gapic_library(
    name = "showcase_java_gapic",
    # ...
    service_yaml = "@com_google_gapic_showcase//schema/google/showcase/v1beta1:showcase_v1beta1.yaml"
    # ...
)

@burkedavison burkedavison requested a review from a team as a code owner October 24, 2022 16:49
@noahdietz noahdietz added the automerge Summon MOG for automerging label Oct 24, 2022
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Summon MOG for automerging label Oct 24, 2022
@noahdietz noahdietz added the automerge Summon MOG for automerging label Oct 24, 2022
@noahdietz noahdietz enabled auto-merge (squash) October 24, 2022 23:55
@noahdietz noahdietz merged commit 5076348 into googleapis:main Oct 24, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Summon MOG for automerging label Oct 24, 2022
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 7, 2023
🤖 I have created a release *beep* *boop*
---


## [0.26.0](https://togithub.com/googleapis/gapic-showcase/compare/v0.25.0...v0.26.0) (2023-03-07)


### Features

* **go:** Update Go version to 1.19 ([#1225](https://togithub.com/googleapis/gapic-showcase/issues/1225)) ([d4b108e](https://togithub.com/googleapis/gapic-showcase/commit/d4b108e16dc91c0ea6d4dec3dca4d3270d3bf47a))


### Bug Fixes

* Build assets for darwin/arm64 ([#1267](https://togithub.com/googleapis/gapic-showcase/issues/1267)) ([0833a57](https://togithub.com/googleapis/gapic-showcase/commit/0833a579131c14582b053f26698fdfe93e465d87))
* Export showcase_v1beta1.yaml from BUILD.bazel to support external GAPIC generation ([#1223](https://togithub.com/googleapis/gapic-showcase/issues/1223)) ([5076348](https://togithub.com/googleapis/gapic-showcase/commit/507634898e208b7ff88784e4ec5f0efd22bff9ab))
* Handle x-http-method-override for PATCH as POST ([#1262](https://togithub.com/googleapis/gapic-showcase/issues/1262)) ([4070ce3](https://togithub.com/googleapis/gapic-showcase/commit/4070ce331bd5e852ccb2f4f2267dce80a9dda9c4))
* Use quotes around extreme int64 values ([#1206](https://togithub.com/googleapis/gapic-showcase/issues/1206)) ([c9d9ff1](https://togithub.com/googleapis/gapic-showcase/commit/c9d9ff191bfd72fe8563625be4074fe4659585d6)), closes [#1205](https://togithub.com/googleapis/gapic-showcase/issues/1205)

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants