This repository has been archived by the owner on Jun 28, 2022. It is now read-only.
Fix string literal character escaping in Ruby generator #2861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #2861 +/- ##
============================================
- Coverage 87.16% 87.16% -0.01%
Complexity 5791 5791
============================================
Files 476 476
Lines 22943 22944 +1
Branches 2475 2476 +1
============================================
Hits 19998 19998
Misses 2111 2111
- Partials 834 835 +1
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #2861 +/- ##
============================================
- Coverage 87.16% 87.16% -0.01%
Complexity 5791 5791
============================================
Files 476 476
Lines 22943 22944 +1
Branches 2475 2476 +1
============================================
Hits 19998 19998
Misses 2111 2111
- Partials 834 835 +1
Continue to review full report at Codecov.
|
alexander-fenster
added a commit
to googleapis/artman
that referenced
this pull request
Jul 1, 2019
Fixes included: - Allow samplegen without sample configs googleapis/gapic-generator#2860 - Fix string literal character escaping in Ruby generator googleapis/gapic-generator#2861
alexander-fenster
added a commit
to googleapis/artman
that referenced
this pull request
Jul 1, 2019
Fixes included: - Allow samplegen without sample configs googleapis/gapic-generator#2860 - Fix string literal character escaping in Ruby generator googleapis/gapic-generator#2861
alexander-fenster
added a commit
to googleapis/artman
that referenced
this pull request
Jul 1, 2019
In this release: #653 is fixed by updating gapic-generator. gapic-generator changes included: - Allow samplegen without sample configs googleapis/gapic-generator#2860 - Fix string literal character escaping in Ruby generator googleapis/gapic-generator#2861
alexander-fenster
added a commit
to googleapis/artman
that referenced
this pull request
Jul 1, 2019
In this release: #653 is fixed by updating gapic-generator. gapic-generator changes included: - Allow samplegen without sample configs googleapis/gapic-generator#2860 - Fix string literal character escaping in Ruby generator googleapis/gapic-generator#2861
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems like missing part of #2782.
Note, the left part of the diff (i.e. file before this PR) for
ruby_library.baselinefile contains non-printable whitespaces.