This repository has been archived by the owner on Jun 28, 2022. It is now read-only.
Python: Add client options. #2853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
lukesneeringer
approved these changes
Jun 25, 2019
|
@lukesneeringer Can I have some help with the remaining failure on gapic-generator-bazel-test? |
Codecov Report
@@ Coverage Diff @@
## master #2853 +/- ##
============================================
+ Coverage 87.15% 87.16% +<.01%
Complexity 5791 5791
============================================
Files 476 476
Lines 22943 22944 +1
Branches 2476 2476
============================================
+ Hits 19997 19998 +1
Misses 2111 2111
Partials 835 835
Continue to review full report at Codecov.
|
alexander-fenster
added a commit
to googleapis/artman
that referenced
this pull request
Jun 28, 2019
Included gapic-generator changes: - go: remove enoding on header request param key googleapis/gapic-generator#2858 - Python: Sync 'list_*' method docstrings with implementation googleapis/gapic-generator#2857 - Python: Add client options googleapis/gapic-generator#2853
alexander-fenster
added a commit
to googleapis/artman
that referenced
this pull request
Jun 28, 2019
This release includes the following fixes: - wrap all parameters in 'apostrophes' #656 - use protoc v3.9.0-rc-1 for PHP #655 Also, the following gapic-generator changes are included: - go: remove enoding on header request param key googleapis/gapic-generator#2858 - Python: Sync 'list_*' method docstrings with implementation googleapis/gapic-generator#2857 - Python: Add client options googleapis/gapic-generator#2853
alexander-fenster
added a commit
to googleapis/artman
that referenced
this pull request
Jun 28, 2019
Included gapic-generator changes: - go: remove enoding on header request param key googleapis/gapic-generator#2858 - Python: Sync 'list_*' method docstrings with implementation googleapis/gapic-generator#2857 - Python: Add client options googleapis/gapic-generator#2853
alexander-fenster
added a commit
to googleapis/artman
that referenced
this pull request
Jun 28, 2019
This release includes the following fixes: - wrap all parameters in 'apostrophes' #656 - use protoc v3.9.0-rc-1 for PHP #655 Also, the following gapic-generator changes are included: - go: remove enoding on header request param key googleapis/gapic-generator#2858 - Python: Sync 'list_*' method docstrings with implementation googleapis/gapic-generator#2857 - Python: Add client options googleapis/gapic-generator#2853
busunkim96
added a commit
to busunkim96/gapic-generator
that referenced
this pull request
Nov 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests will fail until there is a new release of api-core.