This repository has been archived by the owner on Jun 28, 2022. It is now read-only.
Add sample_config.proto to the config_java_proto BUILD target #2852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
fyi @noahdietz @hzyi-google @alexander-fenster |
noahdietz
approved these changes
Jun 22, 2019
vam-google
approved these changes
Jun 24, 2019
BUILD.bazel
Outdated
| java_proto_library( | ||
| name = "config_java_proto", | ||
| deps = [":config_proto", | ||
| ":config_v2_proto"], | ||
| ":config_v2_proto", | ||
| ":sample_config_proto"], |
There was a problem hiding this comment.
Looks like this mixes tabs and spaces. Please convert it to spaces-only.
alexander-fenster
added a commit
to googleapis/artman
that referenced
this pull request
Jun 26, 2019
Changes included are fixes: - samplegen: add sample_config.proto to the config_java_proto BUILD target googleapis/gapic-generator#2852 - go: URL encode x-goog-request-params googleapis/gapic-generator#2851 - ruby: ake it possible to pass metadata to the operations client googleapis/gapic-generator#2856
alexander-fenster
added a commit
to googleapis/artman
that referenced
this pull request
Jun 26, 2019
Changes included are fixes: - samplegen: add sample_config.proto to the config_java_proto BUILD target googleapis/gapic-generator#2852 - go: URL encode x-goog-request-params googleapis/gapic-generator#2851 - ruby: ake it possible to pass metadata to the operations client googleapis/gapic-generator#2856
alexander-fenster
added a commit
to googleapis/artman
that referenced
this pull request
Jun 26, 2019
Changes included in this release are fixes: In artman: - pass the specific YAML loader to yaml.load #648 - fix --local runs #650 In gapic-generator: - samplegen: add sample_config.proto to the config_java_proto BUILD target googleapis/gapic-generator#2852 - go: URL encode x-goog-request-params googleapis/gapic-generator#2851 - ruby: ake it possible to pass metadata to the operations client googleapis/gapic-generator#2856
alexander-fenster
added a commit
to googleapis/artman
that referenced
this pull request
Jun 26, 2019
Changes included in this release are fixes: In artman: - pass the specific YAML loader to yaml.load #648 - fix --local runs #650 In gapic-generator: - samplegen: add sample_config.proto to the config_java_proto BUILD target googleapis/gapic-generator#2852 - go: URL encode x-goog-request-params googleapis/gapic-generator#2851 - ruby: ake it possible to pass metadata to the operations client googleapis/gapic-generator#2856
busunkim96
pushed a commit
to busunkim96/gapic-generator
that referenced
this pull request
Nov 7, 2019
…apis#2852) * Add sample_config.proto to the config_java_proto BUILD target * Cosmetic: convert tab to space
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We accidentally omitted this in #2828