This repository has been archived by the owner on Jun 28, 2022. It is now read-only.
Update enable API link #2198
Merged
Update enable API link #2198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbolinger
added
lang: nodejs
Codecov Report
@@ Coverage Diff @@
## master #2198 +/- ##
=========================================
Coverage 86.86% 86.86%
Complexity 5139 5139
=========================================
Files 456 456
Lines 20386 20386
Branches 2184 2184
=========================================
Hits 17708 17708
Misses 1908 1908
Partials 770 770Continue to review full report at Codecov.
|
|
LGTM for Node, but it's worth mentioning that we don't use the generated |
alexander-fenster
approved these changes
Aug 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2195 by changing how the enable API link is generated.
It seems Ruby and Node share the implementation for this, but the other languages don't. I didn't check to see if they are using correct links but it may be worth updating as a separate change on an as needed basis.