Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

[Ruby] Enable-API link in the README is incorrect #2195

Closed
dazuma opened this issue Aug 3, 2018 · 4 comments
Closed

[Ruby] Enable-API link in the README is incorrect #2195

dazuma opened this issue Aug 3, 2018 · 4 comments
Assignees
Labels
lang: ruby Issues specific to Ruby. priority: p0 Highest priority. Critical issue. P0 implies highest priority. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. yoshi

Comments

@dazuma
Copy link
Member

dazuma commented Aug 3, 2018

The link for enabling the API in the generated README is incorrect.

For example, currently for Redis, the generated README contains this line:

3. [Enable the Google Cloud Memorystore for Redis API.](https://console.cloud.google.com/apis/api/redis)

This link does not work. A link that works correctly might be:

3. [Enable the Google Cloud Memorystore for Redis API.](https://console.cloud.google.com/apis/library/redis.googleapis.com)
@dazuma dazuma added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. lang: ruby Issues specific to Ruby. yoshi labels Aug 3, 2018
@jbolinger jbolinger self-assigned this Aug 3, 2018
@jbolinger jbolinger added the priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. label Aug 3, 2018
@dazuma dazuma reopened this Aug 14, 2018
@dazuma dazuma added priority: p0 Highest priority. Critical issue. P0 implies highest priority. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Aug 14, 2018
@dazuma
Copy link
Member Author

dazuma commented Aug 14, 2018

This is still broken in 0.15.0. Now it's creating links of the form https://console.cloud.google.com/apis/library/api/redis.googleapis.com which does not work.

Either of the following alternatives appear to work:

The former is probably preferred, as it results in fewer redirects.

@jbolinger
Copy link
Contributor

Oh sorry, it looks like I left the old /api/portion.

@dazuma
Copy link
Member Author

dazuma commented Aug 14, 2018

Fix verified in 0.15.1.

@jbolinger
Copy link
Contributor

thanks for confirming @dazuma! Closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lang: ruby Issues specific to Ruby. priority: p0 Highest priority. Critical issue. P0 implies highest priority. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. yoshi
Projects
None yet
Development

No branches or pull requests

2 participants