[PHP] Namespace inconsistency during deprecation

[tmatsuo]

We're trying to update the KMS client lib for PHP. The newly generated code is using a nicer namespace like Google\Cloud\Kms\V1\CryptoKey\CryptoKeyPurpose instead of Google\Cloud\Kms\V1\CryptoKey_CryptoKeyPurpose. Also the generator keeps the old namespaced class with a deprecation warning.

This is a great feature, but we found there are some usages of old classes in various places.

1. Google\Cloud\Kms\V1\Gapic\KeyManagementServiceGapicClient
2. \Google\Cloud\Kms\V1\CryptoKey.php
3. Some occurrences in the unit tests \Google\Cloud\Kms\Tests\Unit\V1\KeyManagementServiceClientTest

For 1, this is the sample code in the doc comment, so it is basically telling users to use the deprecated class which will be removed with the next release. I think the sample code should use the newer class name.

For 2 and 3, I still think it is cleaner to use the newer namespace.

[vchudnov-g]

@michaelbausor Updates?

[andreamlin]

@michaelbausor Updates?

[jbolinger]

@michaelbausor any updates?

[landrito]

@michaelbausor any updates?

[jbolinger]

@michaelbausor any updates?

[michaelbausor]

No update at this time.

[vchudnov-g]

@michaelbausor Could you provide an update and/or lower the priority if appropriate?

[michaelbausor]

This will be fixed in #2757

[vchudnov-g]

@hzyi-google Did #2757 fix this? If so could you close this issue?

[yihanzhen]

Fixed by #2757.