Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicate path Templates for resources #332

Closed
xiaozhenliu-gg5 opened this issue Mar 14, 2020 · 1 comment · Fixed by #333
Closed

duplicate path Templates for resources #332

xiaozhenliu-gg5 opened this issue Mar 14, 2020 · 1 comment · Fixed by #333
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@xiaozhenliu-gg5
Copy link
Contributor

When testing logging API, the projectPath is added twice, which results in compile error:

An object literal cannot have multiple properties with the same name in strict mode.

This happens in logging_service, metric_service, config_service

@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Mar 14, 2020
@xiaozhenliu-gg5 xiaozhenliu-gg5 added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Mar 16, 2020
@yoshi-automation yoshi-automation removed the triage me I really want to be triaged. label Mar 16, 2020
@xiaozhenliu-gg5
Copy link
Contributor Author

xiaozhenliu-gg5 commented Mar 16, 2020

After debugging, I found that only name of the resource is duplicate but the pattern is not.

      projectPathTemplate: new this._gaxModule.PathTemplate(
        'projects/{project}/cmekSettings'
      ),
      projectPathTemplate: new this._gaxModule.PathTemplate(
        'projects/{project}'
      ),

For the first case, we now give it name projectCmekSettings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants