Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing params for resource path constructor #204

Closed
xiaozhenliu-gg5 opened this issue Jan 23, 2020 · 0 comments · Fixed by #206
Closed

missing params for resource path constructor #204

xiaozhenliu-gg5 opened this issue Jan 23, 2020 · 0 comments · Fixed by #206
Assignees
Labels
🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@xiaozhenliu-gg5
Copy link
Contributor

xiaozhenliu-gg5 commented Jan 23, 2020

For @google-cloud/kms path of some resources misses parameters, like keyRingPath it should be

  keyRingPath(project, location, keyRing) {
    return this._pathTemplates.keyRingPathTemplate.render({
      project: project,
      location: location,
      key_ring: keyRing,
    });
  }

but we got

  keyRingPath(project: string, location: string) {
    return this._pathTemplates.keyringPathTemplate.render({
      project,
      location,
    });
  }

and also that's why we don't miss some match function like:

  matchKeyRingFromKeyRingName(keyRingName) {
    return this._pathTemplates.keyRingPathTemplate.match(keyRingName).key_ring;
  }

Reference PR: googleapis/nodejs-kms#264

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
3 participants