Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@google-cloud/billing-budgets API generating failing system tests #140

Closed
bcoe opened this issue Nov 15, 2019 · 1 comment
Closed

@google-cloud/billing-budgets API generating failing system tests #140

bcoe opened this issue Nov 15, 2019 · 1 comment
Assignees
@alexander-fenster
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@bcoe
Copy link
Contributor

bcoe commented Nov 15, 2019

The system tests generated for billing-budgets attempt to load a module called billing, rather than @google-cloud/billing-budgets:

/usr/local/google/home/bencoe/google/nodejs-billing-budgets/system-test/fixtures/sample/src/index.js
  19:25  error  "budgets" is not found                                    node/no-missing-require
  22:9   error  'budgetServiceClient' is assigned a value but never used  no-unused-vars
@bcoe bcoe added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Nov 15, 2019
@alexander-fenster
Copy link
Contributor

Will be taken care of by #134.

@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexander-fenster alexander-fenster

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bcoe @alexander-fenster @yoshi-automation