Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use pack-n-play for pack test #129

Closed
alexander-fenster opened this issue Nov 12, 2019 · 0 comments · Fixed by #132
Closed

use pack-n-play for pack test #129

alexander-fenster opened this issue Nov 12, 2019 · 0 comments · Fixed by #132
Assignees
@xiaozhenliu-gg5
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@alexander-fenster
Copy link
Contributor

Replace our generated pack test with a test that uses https://github.com/google/pack-n-play. It will likely require some changes to pack-n-play module, at least use npm pack for packing and not just tar.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xiaozhenliu-gg5 xiaozhenliu-gg5

Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: replace system test with pack-n-play googleapis/gapic-generator-typescript
2 participants
@alexander-fenster @xiaozhenliu-gg5