Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streaming interface for paging calls #112

Closed
alexander-fenster opened this issue Nov 7, 2019 · 0 comments · Fixed by #116
Closed

streaming interface for paging calls #112

alexander-fenster opened this issue Nov 7, 2019 · 0 comments · Fixed by #116
Assignees
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@alexander-fenster
Copy link
Contributor

Who knew we had this?

https://github.com/googleapis/gapic-generator/blob/e3501faea84f61be2f59bd49a7740a486a02fa6b/src/main/resources/com/google/api/codegen/nodejs/main.snip#L477-L508

Since the generated code does not have unit tests for this, we can also skip testing it, but it makes sense to try adding it to the test showcase applications (both JS and TS).

@alexander-fenster alexander-fenster added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants