Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gapic-common): Honor universe domain in stubs #1008

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

dazuma
Copy link
Member

@dazuma dazuma commented Dec 5, 2023

Partial support for universe domains in GAPICs. This pull request includes changes to gapic-common.

  • Adds optional universe_domain and endpoint_template arguments to stub class constructors. The former is the universe domain in which the call should take place (falling back to the GOOGLE_CLOUD_UNIVERSE_DOMAIN environment variable, then defaulting to googleapis.com). The latter is a template of the endpoint host in which the universe domain component has been replaced with $UNIVERSE_DOMAIN$ (expressed in the constant Gapic::UniverseDomainConcerns::ENDPOINT_SUBSTITUTION). If the latter is not present, the existing endpoint argument is used.
  • Implements determining the endpoint given the universe domain and template.
  • Provides accessors for the universe domain and endpoint that the client object can use to implement its own accessors.
  • Checks credential universe domain for mismatch against configured universe domain.
  • Requires googleauth 1.9 which implements universe domain support.

@dazuma dazuma force-pushed the pr/common-universe branch 4 times, most recently from 189b96c to 0ab1a8f Compare December 8, 2023 19:30
@dazuma dazuma marked this pull request as ready for review December 8, 2023 19:31
@dazuma dazuma requested a review from a team as a code owner December 8, 2023 19:31
@dazuma dazuma merged commit c07eed8 into googleapis:main Dec 11, 2023
10 checks passed
@dazuma dazuma deleted the pr/common-universe branch December 11, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant