Fix: wrap method in async client #1834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohmayr
changed the title
vchudnov-g
reviewed
Nov 6, 2023
tests/system/test_retry.py
Outdated
| @@ -45,10 +45,10 @@ def test_retry_bubble(echo): | |||
|
|
|||
| @pytest.mark.asyncio | |||
| async def test_retry_bubble_async(async_echo): | |||
| with pytest.raises(exceptions.DeadlineExceeded): | |||
| with pytest.raises(exceptions.RetryError): | |||
There was a problem hiding this comment.
Does this mean that the exception the user sees in case of an error changes? If so, we should flag this as a breaking change, since users may be catching the previously raised exception.
There was a problem hiding this comment.
It's more like this test case was defined incorrectly. Both exceptions.DeadlineExceeded and exceptoins.RetryError are raised but we're checking for latter because that confirms that async retry is working as expected.
There was a problem hiding this comment.
Note that exceptions.RetryError was not raised before.
ohmayr
force-pushed
the
fix-wrap-method-in-async-client
branch
from
0ff0980 to
9b3903f
Compare
product-auto-label
bot
added
size: m
parthea
approved these changes
Nov 8, 2023
ohmayr
force-pushed
the
fix-wrap-method-in-async-client
branch
2 times, most recently
from
df677d5 to
dee09be
Compare
ohmayr
force-pushed
the
fix-wrap-method-in-async-client
branch
from
dee09be to
2170b78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: googleapis/google-cloud-python#11415 🦕