Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.65.0 causes sample tests to fail in python-asset #1274

Closed
parthea opened this issue Apr 13, 2022 · 0 comments · Fixed by #1276
Closed

v0.65.0 causes sample tests to fail in python-asset #1274

parthea opened this issue Apr 13, 2022 · 0 comments · Fixed by #1276
Assignees
@parthea
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@parthea
Copy link
Contributor

parthea commented Apr 13, 2022

I merged a renovate bot PR #1227 to update google-api-core which included a change that incorrectly modified retry logic in client libraries. This appears to break samples tests in https://github.com/googleapis/python-asset/pull/409/files. The issue is that instead of getting google_api.core.exceptions.NotFound when a resource is not found we get google.api_core.exceptions.RetryError.

In this commit from google-api-core, grpc was not imported if grpcio-status is not available. The issue was fixed in googleapis/python-api-core#355.

The issue should be resolved with google-api-core==2.7.2 googleapis/python-api-core#358
@parthea parthea added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Apr 13, 2022
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Apr 13, 2022
@parthea parthea self-assigned this Apr 13, 2022
@parthea parthea mentioned this issue Apr 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parthea parthea

Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use google-api-core==2.7.2 googleapis/gapic-generator-python
1 participant
@parthea