Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mypy checks fail with click==8.1.0 #1254

Closed
parthea opened this issue Mar 30, 2022 · 0 comments · Fixed by #1255
Closed

mypy checks fail with click==8.1.0 #1254

parthea opened this issue Mar 30, 2022 · 0 comments · Fixed by #1255
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@parthea
Copy link
Contributor

parthea commented Mar 30, 2022

There is a typing issue with click==8.1.0 which is causing the mypy check to fail in the main branch and #1251. See build log here.

Run nox -s mypy
nox > Running session mypy
nox > Creating virtual environment (virtualenv) using python3.10 in .nox/mypy
nox > python -m pip install mypy 'types-protobuf<=3.19.[7](https://github.com/googleapis/gapic-generator-python/runs/5753213728?check_suite_focus=true#step:5:7)' types-PyYAML types-dataclasses
nox > python -m pip install .
nox > mypy gapic
gapic/cli/generate.py:71: error: <nothing> not callable
Found 1 error in 1 file (checked 36 source files)
@parthea parthea added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant