-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Spanner): Support Emulator via env in Spanner Admin Client #687
Conversation
f09e36e
to
b04b6da
Compare
tests/Unit/ProtoTests/BasicDiregapic/out/src/Gapic/LibraryGapicClient.php
Outdated
Show resolved
Hide resolved
Test failures look unrelated, potential fix: #688 |
Referred: #688 |
@bshaffer Thank you for the quick review, I have resolved your comments. |
I have checked the following test to understand it is in fact working for the Spanner Admin Client.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor suggestion, otherwise this is looking great. Would also love some eyeballs from @noahdietz
…eapis/gapic-generator-php into generator_spanner_emulator_support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment on the integration test but otherwise, LGTM
@ajupazhamayil nit, but we only use tags like |
Sure @bshaffer, Will take care of this from next time onwards. Thank you for the information. |
This PR introduces emulator support in the Spanner Admin Client via an environment variable. These changes will simplify future similar requirements.