Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use new surface LROs in new surface clients #714

Merged
merged 17 commits into from
May 30, 2024

Conversation

bshaffer
Copy link
Contributor

@bshaffer bshaffer commented May 21, 2024

Ensures new surface clients use new surface operations clients for LRO operations by generating a createOperationsClient to override the one in GAX.

alternative to #713 and googleapis/gax-php#571

Depends on googleapis/gax-php#569
Builds on top of #712

@bshaffer bshaffer requested a review from noahdietz May 21, 2024 20:28
@bshaffer bshaffer marked this pull request as ready for review May 23, 2024 05:57
@bshaffer bshaffer requested review from a team as code owners May 23, 2024 05:57
Copy link

snippet-bot bot commented May 23, 2024

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

composer.json Outdated Show resolved Hide resolved
src/Generation/GapicClientV2Generator.php Show resolved Hide resolved
src/Generation/GapicClientV2Generator.php Show resolved Hide resolved
tests/Unit/autoload.php Outdated Show resolved Hide resolved
@bshaffer bshaffer changed the title feat: generate createOperationsClient method for new surface clients feat: use new surface LROs in new surface clients May 30, 2024
@bshaffer bshaffer merged commit 908d92f into main May 30, 2024
4 checks passed
@bshaffer bshaffer deleted the generate-create-operations-client-for-v2 branch May 30, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants