-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use new surface LROs in new surface clients #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here is the summary of changes. You are about to add 4 region tags.
This comment is generated by snippet-bot.
|
This was referenced May 23, 2024
…:googleapis/gapic-generator-php into generate-create-operations-client-for-v2
noahdietz
reviewed
May 29, 2024
noahdietz
approved these changes
May 29, 2024
bshaffer
commented
May 29, 2024
bshaffer
changed the title
feat: generate createOperationsClient method for new surface clients
feat: use new surface LROs in new surface clients
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures new surface clients use new surface operations clients for LRO operations by generating a
createOperationsClient
to override the one in GAX.alternative to #713 and googleapis/gax-php#571
Depends on googleapis/gax-php#569
Builds on top of #712