fix: correct method for supportedTransports #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajupazhamayil
approved these changes
Feb 28, 2024
| @@ -229,8 +229,8 @@ private static function defaultTransport() | |||
| return 'rest'; | |||
| } | |||
|
|
|||
| /** Implements GapicClientTrait::getSupportedTransports. */ | |||
| private static function getSupportedTransports() | |||
| /** Implements GapicClientTrait::supportedTransports. */ | |||
There was a problem hiding this comment.
Curious Q: How did you catch this?
There was a problem hiding this comment.
I was reviewing @yash30201 's doc on Storage V2, and how it only will support grpc, so I wanted to check what the method was that we'd need to generate (which is this one), and noticed the names were different between here and GAX.
There was a problem hiding this comment.
...it would be better if we had a test, though.
There was a problem hiding this comment.
Test added!
noahdietz
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Woops! We've been writing the wrong method name all this time. The method is actually
supportedTransports, but we've been generatinggetSupportedTransports. OH NO!See
ClientOptionsTrait::supportedTransports(called here)