Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snippets: Some snippet region tags do not contain a product name #677

Open
bshaffer opened this issue Dec 12, 2023 · 0 comments
Open

Snippets: Some snippet region tags do not contain a product name #677

bshaffer opened this issue Dec 12, 2023 · 0 comments
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@bshaffer
Copy link
Contributor

See googleapis/google-cloud-php#6864 (comment)

The Snippet Bot is complaining about the region tags (e.g. css_v1_generated_) because they are not "prefixed with a product name"

This may just be because the product prefix hasn't been added to gs://devrel-prod-settings/products.json (see googleapis/repo-automation-bots#4994), but the product css also might not be the right prefix (and instead it should be shoppingcss, for instance).

Do we have a way to customize these product prefixes for the snippets if we do indeed need to change them?

@bshaffer bshaffer added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

1 participant