Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update PHP prebuilt binary, version 7.4.15 #465

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

alexander-fenster
Copy link
Contributor

Using googleapis Docker image 20220222, now with curl enabled. Replaces #462.

Copy link
Collaborator

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will ensure that the binary works inside our specific docker image, but not necessarily when run from a linux workstation or other docker images (unless OwlBot, etc. us the same image). I wonder if we need to include more cached binaries to improve performance in those use cases. Speeding up the kokoro runs is definitely most important though.

@noahdietz noahdietz merged commit 387481a into main Feb 23, 2022
@noahdietz noahdietz deleted the update-binary-20220222T172714 branch February 23, 2022 16:23
@alexander-fenster
Copy link
Contributor Author

not necessarily when run from a linux workstation

I actually checked that it works on a Linux workstation (in its current state).

other docker images

Yes, we need to regularly update them all.

@noahdietz
Copy link
Collaborator

I actually checked that it works on a Linux workstation (in its current state).

Awesome! Thank you for doing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants