fix: correct method for supportedTransports (#692)

src/Generation/GapicClientGenerator.php

@@ -139,7 +139,7 @@ private function generateClass(): PhpClass
             ->withMember($this->operationsClient())
             ->withMember($this->getClientDefaults())
             ->withMember($this->defaultTransport())
-            ->withMember($this->getSupportedTransports())
+            ->withMember($this->supportedTransports())
             ->withMembers($this->resourceMethods())
             ->withMembers($this->operationMethods())
             ->withMember($this->construct())
@@ -488,13 +488,13 @@ private function defaultTransport()
             ));
     }
 
-    private function getSupportedTransports()
+    private function supportedTransports()
     {
         if ($this->serviceDetails->transportType !== Transport::REST) {
             return null;
         }
-        return AST::method('getSupportedTransports')
-            ->withPhpDocText('Implements GapicClientTrait::getSupportedTransports.')
+        return AST::method('supportedTransports')
+            ->withPhpDocText('Implements GapicClientTrait::supportedTransports.')
             ->withAccess(Access::PRIVATE, Access::STATIC)
             ->withBody(AST::block(
                 AST::return(AST::array(['rest']))

src/Generation/GapicClientV2Generator.php

@@ -143,7 +143,7 @@ private function generateClass(): PhpClass
             ->withMember($this->operationsClient())
             ->withMember($this->getClientDefaults())
             ->withMember($this->defaultTransport())
-            ->withMember($this->getSupportedTransports())
+            ->withMember($this->supportedTransports())
             ->withMembers($this->operationMethods())
             ->withMembers($this->resourceMethods())
             ->withMember($this->construct())
@@ -476,13 +476,13 @@ private function defaultTransport()
             ));
     }
 
-    private function getSupportedTransports()
+    private function supportedTransports()
     {
         if ($this->serviceDetails->transportType !== Transport::REST) {
             return null;
         }
-        return AST::method('getSupportedTransports')
-            ->withPhpDocText('Implements GapicClientTrait::getSupportedTransports.')
+        return AST::method('supportedTransports')
+            ->withPhpDocText('Implements GapicClientTrait::supportedTransports.')
             ->withAccess(Access::PRIVATE, Access::STATIC)
             ->withBody(AST::block(
                 AST::return(AST::array(['rest']))

tests/Integration/goldens/compute_small/src/V1/Gapic/AddressesGapicClient.php

@@ -133,8 +133,8 @@ private static function defaultTransport()
         return 'rest';
     }
 
-    /** Implements GapicClientTrait::getSupportedTransports. */
-    private static function getSupportedTransports()
+    /** Implements GapicClientTrait::supportedTransports. */
+    private static function supportedTransports()
     {
         return [
             'rest',

tests/Integration/goldens/compute_small/src/V1/Gapic/RegionOperationsGapicClient.php

@@ -110,8 +110,8 @@ private static function defaultTransport()
         return 'rest';
     }
 
-    /** Implements GapicClientTrait::getSupportedTransports. */
-    private static function getSupportedTransports()
+    /** Implements GapicClientTrait::supportedTransports. */
+    private static function supportedTransports()
     {
         return [
             'rest',

tests/Unit/ProtoTests/BasicDiregapic/out/src/Gapic/LibraryGapicClient.php

@@ -229,8 +229,8 @@ private static function defaultTransport()
         return 'rest';
     }
 
-    /** Implements GapicClientTrait::getSupportedTransports. */
-    private static function getSupportedTransports()
+    /** Implements GapicClientTrait::supportedTransports. */
+    private static function supportedTransports()
     {
         return [
             'rest',

tests/Unit/ProtoTests/ClientTest.php

@@ -0,0 +1,38 @@
+<?php
+/*
+ * Copyright 2024 Google LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+declare(strict_types=1);
+
+namespace Google\Generator\Tests\Unit\ProtoTests;
+
+use PHPUnit\Framework\TestCase;
+use Testing\BasicDiregapic\LibraryClient;
+use Google\ApiCore\InsecureCredentialsWrapper;
+use Google\ApiCore\ValidationException;
+
+final class ClientTest extends TestCase
+{
+    public function testUnsupportedTransportThrowsException()
+    {
+        $this->expectException(ValidationException::class);
+        $this->expectExceptionMessage('Unexpected transport option "grpc". Supported transports: rest');
+
+        $client = new LibraryClient([
+            'transport' => 'grpc',
+            'credentials' => new InsecureCredentialsWrapper(),
+        ]);
+    }
+}

tests/Unit/ProtoTests/CustomLro/out/src/Gapic/CustomLroGapicClient.php

@@ -128,8 +128,8 @@ private static function defaultTransport()
         return 'rest';
     }
 
-    /** Implements GapicClientTrait::getSupportedTransports. */
-    private static function getSupportedTransports()
+    /** Implements GapicClientTrait::supportedTransports. */
+    private static function supportedTransports()
     {
         return [
             'rest',

tests/Unit/ProtoTests/CustomLro/out/src/Gapic/CustomLroOperationsGapicClient.php

@@ -102,8 +102,8 @@ private static function defaultTransport()
         return 'rest';
     }
 
-    /** Implements GapicClientTrait::getSupportedTransports. */
-    private static function getSupportedTransports()
+    /** Implements GapicClientTrait::supportedTransports. */
+    private static function supportedTransports()
     {
         return [
             'rest',