fix: optional-to-required field for Cloud DMS (#649)

googleapis · Sep 7, 2023 · 613baec · 613baec
1 parent b294196
commit 613baec
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/.github/conventional-commit-lint.yaml b/.github/conventional-commit-lint.yaml
@@ -0,0 +1,2 @@
+always_check_pr_title: true
+
diff --git a/src/Generation/FieldDetails.php b/src/Generation/FieldDetails.php
@@ -138,15 +138,16 @@ class FieldDetails
      * AFTER a package's 1.0 release, back to being optional.
      */
     private static $optionalToRequiredFixes = [
-        'google.logging.v2.UpdateCmekSettingsRequest' => ['name', 'cmek_settings'],
-        'google.logging.v2.GetCmekSettingsRequest' => ['name'],
+        'google.cloud.clouddms.v1.DescribeDatabaseEntitiesRequest' => ['tree'],
+        'google.cloud.texttospeech.v1.SynthesizeLongAudioRequest' => ['output_gcs_uri', 'voice'],
         'google.cloud.videointelligence.v1.AnnotateVideoRequest' => ['features'],
+        'google.devtools.artifactregistry.v1beta2.ListFilesRequest' => ['parent'],
+        'google.devtools.artifactregistry.v1beta2.GetFileRequest' => ['name'],
         'google.firestore.v1.BatchWriteRequest' => ['database'],
         'google.firestore.v1.PartitionQueryRequest' => ['parent'],
+        'google.logging.v2.UpdateCmekSettingsRequest' => ['name', 'cmek_settings'],
+        'google.logging.v2.GetCmekSettingsRequest' => ['name'],
         'google.spanner.v1.CreateSessionRequest' => ['session'],
-        'google.devtools.artifactregistry.v1beta2.ListFilesRequest' => ['parent'],
-        'google.devtools.artifactregistry.v1beta2.GetFileRequest' => ['name'],
-        'google.cloud.texttospeech.v1.SynthesizeLongAudioRequest' => ['output_gcs_uri', 'voice'],
     ];
 
     public function __construct(ProtoCatalog $catalog, DescriptorProto $containingMessage, FieldDescriptorProto $field, ?Vector $docLinesOverride = null)