Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gengapic): inject gRPC server stream call opts #1202

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

noahdietz
Copy link
Collaborator

@noahdietz noahdietz commented Dec 19, 2022

Inject default call options for server-stream, gRPC calls. This includes default retry options that will work when trying to establish a new stream.

It looks like, unfortunately, this was errantly removed in #577 and it snuck through review.

Addresses the generator issue mentioned in googleapis/google-cloud-go#5906.

@noahdietz noahdietz marked this pull request as ready for review December 19, 2022 20:31
@noahdietz noahdietz requested review from a team as code owners December 19, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants