From e65012835dee4cfb4aad0c5c4e300b9fd7eb127a Mon Sep 17 00:00:00 2001 From: munahaf Date: Mon, 18 Sep 2023 10:16:17 +0000 Subject: [PATCH 1/2] Comment: Added a missing break statement. --- .../discotoproto3converter/proto3/DocumentToProtoConverter.java | 1 + 1 file changed, 1 insertion(+) diff --git a/src/main/java/com/google/cloud/discotoproto3converter/proto3/DocumentToProtoConverter.java b/src/main/java/com/google/cloud/discotoproto3converter/proto3/DocumentToProtoConverter.java index 89470e6..4d1095c 100644 --- a/src/main/java/com/google/cloud/discotoproto3converter/proto3/DocumentToProtoConverter.java +++ b/src/main/java/com/google/cloud/discotoproto3converter/proto3/DocumentToProtoConverter.java @@ -423,6 +423,7 @@ private Field schemaToField(Schema sch, boolean optional) { break; case EMPTY: valueType = new Message(sch.reference(), true, false, null); + break; case INTEGER: switch (sch.format()) { case INT32: From b5ed7965d3cc62279fbf2e9dc37442528c0f2fd6 Mon Sep 17 00:00:00 2001 From: Munawar Date: Wed, 20 Sep 2023 00:53:09 -0700 Subject: [PATCH 2/2] Updated code formating --- .../discotoproto3converter/proto3/DocumentToProtoConverter.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/com/google/cloud/discotoproto3converter/proto3/DocumentToProtoConverter.java b/src/main/java/com/google/cloud/discotoproto3converter/proto3/DocumentToProtoConverter.java index 4d1095c..e3f489a 100644 --- a/src/main/java/com/google/cloud/discotoproto3converter/proto3/DocumentToProtoConverter.java +++ b/src/main/java/com/google/cloud/discotoproto3converter/proto3/DocumentToProtoConverter.java @@ -423,7 +423,7 @@ private Field schemaToField(Schema sch, boolean optional) { break; case EMPTY: valueType = new Message(sch.reference(), true, false, null); - break; + break; case INTEGER: switch (sch.format()) { case INT32: