Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails on Windows #63

Open
mxrch opened this issue Dec 6, 2021 · 2 comments
Open

Build fails on Windows #63

mxrch opened this issue Dec 6, 2021 · 2 comments
Assignees
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@mxrch
Copy link

mxrch commented Dec 6, 2021

Environment details

  • Programming language: Java
  • OS: Windows 11
  • Language runtime version: Oracle JDK 17, with MVN 3.8.4

Steps to reproduce

  1. Git clone the repo
  2. Launch "mvn package" in it

Here are the tests that fails :

Results :

Failed tests:   convertWithIgnorelist(com.google.cloud.discotoproto3converter.DiscoToProto3ConverterAppTest): expected:<(..)ght 2020 Google LLC[
  convertEnumsAsStrings(com.google.cloud.discotoproto3converter.DiscoToProto3ConverterAppTest): expected:<...ight 2020 G(..)e LLC[
(..)nvert(com.google.cloud.discotoproto3converter.DiscoToProto3ConverterAppTest): expected:<...ight 2020 Google LLC[
(..)nvert(com.google.cloud.discotoproto3converter.GapicYamlGeneratorAppTest): expected:<...ight 2020 Google LLC[

Tests run: 5, Failures: 4, Errors: 0, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  1.563 s
[INFO] Finished at: 2021-12-07T00:52:13+01:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.12.4:test (default-test) on project disco-to-proto3-converter: There are test failures.
[ERROR]
[ERROR] Please refer to C:\Users\thher\disco-to-proto3-converter\target\surefire-reports for the individual test results.
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

I can confirm that it works on Linux, with OpenJDK.

@mxrch mxrch added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Dec 6, 2021
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Mar 6, 2022
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Jun 5, 2022
@noahdietz noahdietz added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. 🚨 This issue needs some love. labels Jun 27, 2022
@noahdietz
Copy link
Collaborator

Thank you for filing this @mxrch.

I've bumped this down to P3 as this repo is not an official Google product. We run this in CI using linux-based machines, so Windows environments aren't exactly a priority. That said, perhaps there is an easy fix.

@vam-google what should we do about this?

@noahdietz
Copy link
Collaborator

For the record, we may close this as Won't Fix for the reasons mentioned above, but I'd like to at least triage it first. @mxrch if you find a fix, you may contribute it and we'd be happy to review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

4 participants