Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merging protos created from the same source should be a no-op #114

Open
vchudnov-g opened this issue Feb 3, 2024 · 0 comments
Open

merging protos created from the same source should be a no-op #114

vchudnov-g opened this issue Feb 3, 2024 · 0 comments
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@vchudnov-g
Copy link
Collaborator

In the course of working on #112 , I discovered that merging a synthetic proto with itself, which one would expect to be a no-op, actually changes the protos.

Two ways to see this;

  1. In src/test/java/com/google/cloud/discotoproto3converter/DiscoToProto3ConverterAppTest.java, re-enable the assertEquals in convertWithIdempotentMerge and examine the test failure. Some fields get extra comments.
  2. Use the reproduction steps in merging protos with Any fields generates a fictional, invalid proto field #113, which is related
@vchudnov-g vchudnov-g added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

1 participant