Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make autoloader more efficient #45

Merged
merged 2 commits into from
Oct 5, 2022
Merged

feat: make autoloader more efficient #45

merged 2 commits into from
Oct 5, 2022

Conversation

bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Sep 29, 2022 •
edited
Loading

The autoloader we have now will match every Google-namespaced class and check if it exists. This autoloader ensures that only the matching prefixes are checked.

@bshaffer bshaffer requested a review from a team as a code owner September 29, 2022 21:18
dwsupplee
dwsupplee approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@dwsupplee dwsupplee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're going to do this, should do the same for the metadata classes too?

@bshaffer
Copy link
Contributor Author

bshaffer commented Oct 5, 2022

If we're going to do this, should do the same for the metadata classes too?

good idea!

@bshaffer bshaffer merged commit cdff58a into main Oct 5, 2022
@bshaffer bshaffer deleted the more-explicit-autoloader branch October 5, 2022 23:16
@release-please release-please bot mentioned this pull request Oct 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwsupplee dwsupplee dwsupplee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bshaffer @dwsupplee